fix: improve cherry-pick handling and version sync process to avoid conflicts - #81
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe release workflow now uses npm trusted publishing, validates the npm CLI version, generates package links dynamically, synchronizes versions directly, and regenerates the lockfile. The version-sync script reports merge conflicts and invalid JSON. Conflict cleanup resets the working tree after dismissing the cherry-pick sequencer. ChangesRelease automation
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant ReleaseJob as GitHub Actions release job
participant NpmCli as npm CLI
participant NpmRegistry as npm registry
ReleaseJob->>NpmCli: install and validate npm >= 11.5.1
ReleaseJob->>NpmRegistry: publish packages with OIDC credentials
ReleaseJob->>ReleaseJob: scan libs/*/package.json for release links
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/publish-release.yml:
- Around line 101-102: Update the npm installation command in the release
workflow to use the approved exact npm CLI version compatible with .nvmrc
instead of npm@latest, while preserving the existing fallback warning and
minimum-version validation.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 63128eb1-fb5a-43fa-8675-8c1bab7a00e2
📒 Files selected for processing (4)
.github/RELEASE_WORKFLOW.md.github/workflows/cherry-pick-prompt.yml.github/workflows/publish-release.ymlscripts/sync-versions.mjs
Cherry-pick CreatedA cherry-pick PR to Please review and merge if this change should also be in If the cherry-pick is not needed, close the PR. |
Summary by CodeRabbit
Chores
Bug Fixes
Documentation