docs: add example how to configure custom webhook timeout - #1016
docs: add example how to configure custom webhook timeout#1016Matcham89 wants to merge 3 commits into
Conversation
33739e9 to
b0a7b5a
Compare
|
Thank you for working on this! The core mechanism the PR documents is correct and works. I confirmed it against the agentgateway source and by running it in a kind cluster with a real slow webhook. Two supporting sentences are wrong or misleading, and one important consequence of the change is missing. VerificationTested in a kind cluster using
Corroborating source evidence:
Good catch documenting the leading slash. Blocking1. "The backend host must include a port when the webhook does not use the default HTTP port." — this is wrongThe port is always required. Dropping it fails at startup: Suggested replacement:
2. The
|
kristin-kronstain-brown
left a comment
There was a problem hiding this comment.
Requested changes above.
Signed-off-by: Matcham89 <cjmatcham@hotmail.co.uk>
3e9186a to
d3beb73
Compare
Signed-off-by: Matcham89 <cjmatcham@hotmail.co.uk>
d3beb73 to
8eccc87
Compare
|
Thank you for the quick turnaround. All of the items look addressed. In reviewing another time, a couple other things might be worth taking a look at. 1.
|
Signed-off-by: Matcham89 <cjmatcham@hotmail.co.uk>


Company
Not applicable.
Contribution summary
Logo file
Listing
Preview