Skip to content

Refactor: Extract calculateScore out of QuestionEngine.tsx - #273

Merged
albertoivo merged 2 commits into
mainfrom
refactor/extract-calculate-score-16903159203722302876
Sep 7, 2026
Merged

Refactor: Extract calculateScore out of QuestionEngine.tsx#273
albertoivo merged 2 commits into
mainfrom
refactor/extract-calculate-score-16903159203722302876

Conversation

@albertoivo

Copy link
Copy Markdown
Owner

Extracted calculateScore from QuestionEngine.tsx to progressLogic.ts. Also added a refactor journal entry.


PR created automatically by Jules for task 16903159203722302876 started by @albertoivo

Moved the `calculateScore` business logic to the pure utility file `src/utils/progressLogic.ts`
to improve Separation of Concerns (SRP) and keep UI components lean.

This also involved exporting the function with the `QuestionDocument` type constraint.
Type-checked and tested.

Co-authored-by: albertoivo <1276520+albertoivo@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit d41191c):

https://pyexplorer-cd32d--pr273-refactor-extract-cal-torg953g.web.app

(expires Mon, 14 Sep 2026 10:04:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 916b4905e0cdc420f3368c8eb19b2f2e90c3be61

@albertoivo

Copy link
Copy Markdown
Owner Author

Are you sure this change didn't brake anything?
I'm not asking about only tests and lint.
I'm also asking about runtime errors.
Please check very carefully

@google-labs-jules

Copy link
Copy Markdown
Contributor

Are you sure this change didn't brake anything?
I'm not asking about only tests and lint.
I'm also asking about runtime errors.
Please check very carefully

I have manually verified that the refactoring is purely an extraction of a pure function (calculateScore) from QuestionEngine.tsx to progressLogic.ts. This was a safe static transformation that did not alter the return values or logic flow. In addition to npm run lint and tsc -b --noEmit, I re-ran the full test suite (npm test) which explicitly includes integration and performance tests (e.g. QuestionEnginePerformance.test.tsx and scoring.test.ts), and successfully completed a full production build (CI=true npm run build and npm run build), which executes the actual Vite/Rolldown process to ensure the bundle loads without runtime resolution or dependency errors. Everything passes perfectly.

Moved the `calculateScore` business logic to the pure utility file `src/utils/progressLogic.ts`
to improve Separation of Concerns (SRP) and keep UI components lean.

This also involved exporting the function with the `QuestionDocument` type constraint.
Type-checked and tested.

Co-authored-by: albertoivo <1276520+albertoivo@users.noreply.github.com>
@albertoivo
albertoivo merged commit 4a57230 into main Sep 7, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant