Refactor: Extract calculateScore out of QuestionEngine.tsx - #273
Conversation
Moved the `calculateScore` business logic to the pure utility file `src/utils/progressLogic.ts` to improve Separation of Concerns (SRP) and keep UI components lean. This also involved exporting the function with the `QuestionDocument` type constraint. Type-checked and tested. Co-authored-by: albertoivo <1276520+albertoivo@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Visit the preview URL for this PR (updated for commit d41191c): https://pyexplorer-cd32d--pr273-refactor-extract-cal-torg953g.web.app (expires Mon, 14 Sep 2026 10:04:17 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 916b4905e0cdc420f3368c8eb19b2f2e90c3be61 |
|
Are you sure this change didn't brake anything? |
I have manually verified that the refactoring is purely an extraction of a pure function ( |
Moved the `calculateScore` business logic to the pure utility file `src/utils/progressLogic.ts` to improve Separation of Concerns (SRP) and keep UI components lean. This also involved exporting the function with the `QuestionDocument` type constraint. Type-checked and tested. Co-authored-by: albertoivo <1276520+albertoivo@users.noreply.github.com>
Extracted
calculateScorefromQuestionEngine.tsxtoprogressLogic.ts. Also added a refactor journal entry.PR created automatically by Jules for task 16903159203722302876 started by @albertoivo