Detect existing GA key-event setting mismatches - #212
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GA setup utility currently treats an existing generate_lead registration as configured even when its counting method or default value differs from the intended settings. Flag these mismatches, return nonzero for --check, block apply without editing existing entries, and verify the settings again after creation.
The September 20 check confirms all registrations exist but still returns a USD 1 default. Record that discrepancy, the continued Coolify read-permission denial, the successful 101-URL crawl and intercepted form/pageview checks. Keep the reporting grant and schedules unchanged; the next IVR content improvement is prepared privately and held behind deployment/attribution gates.
Validation: 21 measurement-utility tests and all 51 SEO-operations tests pass; claims audit passes 191 files; git diff --check passes. No GA administrative write, live enquiry, paid DataForSEO call or public article edit occurred.