Trends: keep the second breakdown dimension across a range change - #12
Merged
Merged
Conversation
…hange The event explorer already computes a group_by x second_group_by table, but second_group_by was dropped from the date-picker's hidden fields and from the Clear-filter check, so changing the range silently collapsed a two-dimensional breakdown back to one. Carry it through both, and cover the two-dimensional path with request specs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The event explorer already builds a
group_by × second_group_bytable (@multi_breakdown), butsecond_group_bywas missing from the date-picker's hidden fields and from the "Clear" visibility check — so adjusting the date range dropped the second dimension and collapsed the view back to a single group-by.second_group_bytoextra_hidden_fieldson the event-explorer headerNo schema change. Suite 275 green, rubocop clean, brakeman 0.