Sparklines on dashboard widgets - #16
Merged
Merged
Conversation
WidgetMetric now also returns a zero-filled daily series across the widget's window, and the card draws it as a small inline-SVG polyline (no JS, no charting library). The sparkline is skipped for a flat-zero or single-point series. - WidgetMetric::Result gains :series; #call groups rollups by date and zero-fills every day in start_date..today - DashboardsHelper#sparkline normalises the series to a polyline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #11 / #14. Each count-shaped widget now shows a tiny trend under its headline number.
WidgetMetric::Resultgains aseries— daily counts grouped from the rollups and zero-filled for every day in the window.DashboardsHelper#sparklinerenders a normalised<polyline>in an inline SVG. No JS, no charting dependency. Returns nil (nothing drawn) for a flat-zero or single-point series.Specs:
WidgetMetricseries length/values/zero-fill; helper nil-cases, point count, and that the max sits nearest the top. Suite 305 green, rubocop clean, brakeman 0. No migration.