fix: dismiss the full-battery alert when the charger comes out

[almothafar]

The "Battery fully charged" notification stayed on screen after unplugging.

The bug

decideChargingOrFull treated BATTERY_STATUS_FULL as the whole trigger, never asking whether a charger was actually connected. Plenty of devices keep reporting that status while sitting at 100% with the cable already out, so on unplug:

1. PowerConnectionReceiver.handleChargerDisconnected cancels the notification and clears fullNotified to re-arm the next charge session.
2. The very next ACTION_BATTERY_CHANGED — still reporting FULL, now against a freshly cleared flag — posts the alert straight back.

The alert is cleared and immediately re-posted, which reads as a notification that refuses to go away. With the sticky-notification preference on it carries FLAG_NO_CLEAR, so it can't be swiped either.

A second path reached the same symptom: when the process is killed mid-charge (doze, OEM task killers) nobody sees the unplug broadcast, so nothing ever clears the alert.

The fix

The full alert is now bounded by the charger, not by the status.

• BatteryLevelReceiver reads EXTRA_PLUGGED and passes it into the decision core; the alert fires only on full && plugged, so off the charger it cannot re-post itself.
• A shown full alert is dismissed from the plugged state rather than from the unplug transition alone, so a transition missed while the process was dead still resolves on the next broadcast instead of stranding the notification until the following charge. The same step re-arms the episode, matching what PowerConnectionReceiver already does on the transition it does see.
• Dismissal runs before dispatch in onReceive: level alerts share one notification ID, so an alert decided on the same broadcast (a critical one, on a battery unplugged at full that then drained) must replace the stale notification rather than be cancelled after it.

Unchanged: the once-per-charge behaviour, the (warning, FULL_PERCENTAGE] re-arm band, and re-firing when a charger is connected at an already-full battery — each pinned by a test.

Tests

Five new cases in BatteryLevelReceiverDecisionTest covering the regression itself (unplugged while still reporting FULL), the dismissal of a stale alert on both the charging-or-full and the discharge branch, the critical-alert-survives-the-dismissal ordering, and the re-plug case. testDebugUnitTest and lintDebug both pass.

Also drops an unused constant (FRESH) in the test file.

---

Generated by Claude Code