feat: crash music volume config - #2076
Open
rapbattlegod32 wants to merge 3 commits into
Open
rapbattlegod32 wants to merge 3 commits into
rapbattlegod32 wants to merge 3 commits into
Conversation
github-actions
Bot
added
S: Untriaged
drtheodor
requested changes
Jun 9, 2026
github-actions
Bot
added
S: Awaiting Changes
drtheodor
self-requested a review
June 11, 2026 08:45
github-actions
Bot
added
S: Needs Review
drtheodor
requested changes
Jun 11, 2026
Comment on lines
+188
to
+189
| ClientPlayNetworking.registerGlobalReceiver(TravelHandler.CRASH_MUSIC, (client, handler, buf, responseSender) -> | ||
| client.execute(ClientCrashMusicSoundHandler::play)); |
Member
There was a problem hiding this comment.
absolutely not
see how flight sound and alarms are played
github-actions
Bot
added
S: Awaiting Changes
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| return tardis != null && !tardis.crash().isNormal(); | ||
| } | ||
|
|
||
| public void tick(MinecraftClient client) { |
github-actions
Bot
added
the
S: Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
Bot
added
S: Needs Review
drtheodor
self-requested a review
June 28, 2026 03:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
add volume config for the new crash music
Why / Balance
too loud imo
Requirements
🆑