Conversation
Peter1169
marked this pull request as ready for review
July 31, 2026 19:31
drtheodor
requested changes
Aug 22, 2026
drtheodor
left a comment
Member
There was a problem hiding this comment.
CHANGE_WORLD is already working properly, there's no need to re-query the current tardis from the cache each time (not to mention that doing string -> uuid is slightly expensive.
this method gets called in rendering a lot, and I don't see a reason to why it should re-query every call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
This makes the individual TARDIS client sound handlers stop and reset their own sounds when the client context they depend on is no longer valid.
This intentionally does not add a central sound shutdown call to
ClientTardisManager.Why / Balance
This has no gameplay balance impact. It prevents TARDIS-specific sounds from continuing after leaving an interior, changing worlds, dying, disconnecting or otherwise losing the client-side TARDIS context that created them.
Keeping cleanup inside each handler also means future sound handlers can define the state they own instead of depending on an unrelated TARDIS data manager to maintain a complete global list.
Technical details
ClientTardisUtil#getCurrentTardisnow verifies that its reference matches the TARDIS UUID attached to the active client world.ClientFlightMusicHandler,ClientHumHandlerandSonicSoundHandlerperform their own context checks and cleanup.Media
N/A
Requirements
Breaking changes
N/A
Changelog
🆑