Skip to content

Add support for NO_OVERWRITE config option - #97

Open
Chaz6 wants to merge 1 commit into
amietn:masterfrom
Chaz6:patch-1
Open

Chaz6 wants to merge 1 commit into
amietn:masterfrom
Chaz6:patch-1

Conversation

@Chaz6

@Chaz6 Chaz6 commented Aug 9, 2021

Copy link
Copy Markdown

No description provided.

@amietn

amietn commented Aug 14, 2021

Copy link
Copy Markdown
Owner

Thank you for contributing!

I believe this does not work if no_overwrite is set to False in the config file. It would still be interpreted as True.

One solution would be to call config.getboolean() instead of config.get() for options of boolean type.

@Chaz6

Chaz6 commented Aug 15, 2021

Copy link
Copy Markdown
Author

Thank you for the feedback, I will amend the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants