[pull] main from forem:main - #370
Merged
Merged
Conversation
…ding broadcasts to the rollout cohort (#23774) * Stop overriding the Customer.io template sender DeliveryMethods::CustomerIo copied mail.from into the App API payload on every send. Customer.io treats a from in the request as an override of the sender identity configured on the transactional message, so every template send went out as ForemInstance.from_email_address regardless of what the message was set up with in Customer.io. Only send from on the body-passthrough path (no transactional_message_id), where the API needs it -- mirroring the existing guard on body. A mailer can still override it explicitly by passing from: through customerio_delivery_options. Claude-Session: https://claude.ai/code/session_012jDiQz996H7daE3dZbz1Hu * Don't double-send broadcasts to the Customer.io rollout cohort The cutover guards in Email, Emails::BatchCustomSendWorker and Admin::EmailsController all key off ForemInstance.customerio_email_cutover?, which reads the *global* :customerio_email_delivery state. The flag rolls out per actor, so while it is partially on the guards stay false and Forem keeps broadcasting to everyone -- including the enabled cohort, who are already getting the same broadcast from the Customer.io side. Skip flag-enabled recipients in the batch worker, with a per-recipient backstop in CustomMailer that also covers Emails::DripEmailWorker (it builds its sends itself and never passes through the batch worker). Test sends stay exempt so admins keep their preview during the rollout. Claude-Session: https://claude.ai/code/session_012jDiQz996H7daE3dZbz1Hu
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )