Conversation
The two affected driver structs are passed to register_rpmsg_driver() which takes care for assigning drv.owner. So the explicit assignment in the driver is useless boilerplate and can be dropped. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
adi_rpmsg_driver is passed to module_platform_driver() which copes for assigning .driver.owner overwriting the explicit initialisation. So drop this useless assignment und thus reduce boilerplate. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
adi_wdt_driver is passed to module_platform_driver() which copes for assigning .driver.owner overwriting the explicit initialisation. So drop this useless assignment und thus reduce boilerplate. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
nunojsa
approved these changes
Sep 17, 2026
| .owner = THIS_MODULE, | ||
| #if defined(CONFIG_OF) | ||
| .of_match_table = of_match_ptr(adi_wdt_dt_ids), | ||
| #endif |
Collaborator
There was a problem hiding this comment.
While at it, I guess we could also drop the useless #if defined(CONFIG_OF). Or one step further, of_match_ptr().
Collaborator
Author
There was a problem hiding this comment.
Ack, I spotted that one, too, but it was shortly before the lunch break ... :-D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This is just a drive-by cleanup that I noticed while working on the rpmsg driver.
PR Type
PR Checklist