Skip to content

Is the RRDBNet correct? #52

Description

@michaelwangyuan

In the forward function of the RRDBNet

def forward(self, x, get_steps=False):
    fea = self.conv_first(x)
    block_idxs = opt_get(self.opt, ['network_G', 'flow', 'stackRRDB', 'blocks']) or []
    block_results = {}
    for idx, m in enumerate(self.RRDB_trunk.children()):            
        fea = m(fea)                                               
        for b in block_idxs:
            if b == idx:
                block_results["block_{}".format(idx)] = fea         
    trunk = self.trunk_conv(fea)
    last_lr_fea = fea + trunk             

It seems that fea in the last_lr_fea=fea+trunk line is the feature of the last RRDB block before self.turnk_conv. But to my knowledge, the skip connection should be last_lr_fea = x+ trunk. Is my understanding right?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions