Conversation
Introduce id based equality to alleviate problems related to the fact that body occurrences are built on the fly. Component should not need but added for consistency
smereu
requested review from
RobPasMue,
b-matteo,
jacobrkerstetter,
mlkaplan36 and
umutsoysalansys
February 24, 2026 16:21
mlkaplan36
previously approved these changes
Feb 24, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2604 +/- ##
==========================================
+ Coverage 94.88% 94.89% +0.01%
==========================================
Files 173 173
Lines 14441 14449 +8
==========================================
+ Hits 13702 13712 +10
+ Misses 739 737 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
add doc string
…sys-geometry into fix/id_based_equality
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce id based equality to alleviate problems created by the fact that body occurrences are built on the fly. Component shouldn't strictly be needed but added for consistency.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist
feat: extrude circle to cylinder)