Skip to content

fix: id based equality - #2604

Open
smereu wants to merge 45 commits into
mainfrom
fix/id_based_equality
Open

smereu wants to merge 45 commits into
mainfrom
fix/id_based_equality

Conversation

@smereu

@smereu smereu commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

Description

Introduce id based equality to alleviate problems created by the fact that body occurrences are built on the fly. Component shouldn't strictly be needed but added for consistency.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

pyansys-ci-bot and others added 30 commits February 17, 2025 14:31
Introduce id based equality to alleviate problems related to the fact that body occurrences are built on the fly.  Component should not need but added for consistency
@smereu smereu self-assigned this Feb 24, 2026
@smereu
smereu requested a review from a team as a code owner February 24, 2026 16:21
@github-actions github-actions Bot added the bug Something isn't working label Feb 24, 2026
@smereu smereu changed the title Fix/id based equality Fix: id based equality Feb 24, 2026
mlkaplan36
mlkaplan36 previously approved these changes Feb 24, 2026
@codecov

codecov Bot commented Feb 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.89%. Comparing base (623ebb4) to head (0a9140d).
⚠️ Report is 50 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2604      +/-   ##
==========================================
+ Coverage   94.88%   94.89%   +0.01%     
==========================================
  Files         173      173              
  Lines       14441    14449       +8     
==========================================
+ Hits        13702    13712      +10     
+ Misses        739      737       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RobPasMue RobPasMue changed the title Fix: id based equality fix: id based equality Feb 24, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants