Skip to content

docs(examples): adapt solder ball example to use create_fill_pattern - #2944

Draft
RobPasMue with Copilot wants to merge 8 commits into
mainfrom
copilot/featadapt-fill-pattern-example
Draft

RobPasMue with Copilot wants to merge 8 commits into
mainfrom
copilot/featadapt-fill-pattern-example

Conversation

Copilot AI commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Description

Replaces the manual copy+translate+subtract nested loop in the BGA solder ball example with create_fill_pattern, which stamps the entire 3×3 infill hole array in a single API call.

Source model changes:

  • Add PITCH = 1.0 and SOLDER_RADIUS = 0.25 constants; remove pre-sketched seed bodies at origin
  • Subtract one seed cylinder at corner (−1, −1) spanning the full infill height, then call create_fill_pattern(FillPatternType.GRID, margin=PITCH/2, x_spacing=PITCH, y_spacing=PITCH) — 27 individual subtract operations → 1 call
  • Create the 9 solder cylinders + 18 copper pads with straightforward per-position extrude_sketch calls (no copy/translate)

Target model: unchanged — create_fill_pattern targets concave features in a flat host face; the revolve-based solder balls are convex and not applicable.

Please add the deploy-doc-pr label to publish and validate the rendered docs.

Issue linked

Follow-up to #2939.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@codacy-production

codacy-production Bot commented Jul 16, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@RobPasMue RobPasMue added the deploy-pr-doc Deploy pull request documentation label Jul 16, 2026
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jul 16, 2026
@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.89%. Comparing base (c0463f0) to head (8b5c66d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2944   +/-   ##
=======================================
  Coverage   93.89%   93.89%           
=======================================
  Files         175      175           
  Lines       15515    15515           
=======================================
  Hits        14568    14568           
  Misses        947      947           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown

The documentation for this pull request will be available at https://geometry.docs.pyansys.com/pull/2944. Please allow some time for the documentation to be deployed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deploy-pr-doc Deploy pull request documentation documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants