feat: Added MapCatiaSetsToGroups Import Option by Gonzi09 · Pull Request #3031 · ansys/pyansys-geometry

Gonzi09 · 2026-08-12T19:48:24Z

Description

As title mentions

Issue linked

Resolves #3008

Checklist

I have tested my changes locally.
I have added necessary documentation or updated existing documentation.
I have followed the coding style guidelines of this project.
I have added appropriate unit tests.
I have reviewed my changes before submitting this pull request.
I have linked the issue or issues that are solved to the PR if any.
I have assigned this PR to myself.
I have added the minimum version decorator to any new backend method implemented.
I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

codacy-production · 2026-08-12T19:56:25Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results

Complexity 0

Duplication 0

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

codecov · 2026-08-12T20:02:54Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.62%. Comparing base (8f7dde1) to head (975cfcf).

❌ Your project check has failed because the head coverage (89.62%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3031      +/-   ##
==========================================
- Coverage   93.79%   89.62%   -4.17%     
==========================================
  Files         195      185      -10     
  Lines       18171    16723    -1448     
==========================================
- Hits        17043    14988    -2055     
- Misses       1128     1735     +607

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

This PR adds client-side support in PyAnsys Geometry for a CATIA import option that maps CATIA geometric sets/publications into PyGeometry named selection groups, aligning named selection behavior with SpaceClaim/GeometryService.

Changes:

Extend ImportOptions with map_catia_sets_to_groups and publications_only_to_groups.
Add integration tests covering CATIA named selections import and mapping behavior with the new options.
Mark the new CATIA named-selection tests as incompatible on backend versions earlier than 26.1 and add a changelog entry.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

File	Description
`src/ansys/geometry/core/misc/options.py`	Adds new CATIA-related import flags to `ImportOptions`.
`tests/integration/test_design_import.py`	Adds integration coverage for CATIA named selections + mapping behavior.
`tests/_incompatible_tests.yml`	Skips the new CATIA named selection tests on backends older than 26.1.
`doc/changelog.d/3031.added.md`	Documents the newly added import option in the changelog.

Suppressed comments (1)

tests/integration/test_design_import.py:484

ImportOptions is already imported at module scope (from ansys.geometry.core.misc import ... ImportOptions). The additional local import is redundant and uses a different import path, which makes the test inconsistent and slightly harder to maintain.

def test_design_import_catia_named_selections_with_publications(modeler: Modeler):
    """Test importing a CATIA V5 file with publications as named selection groups."""
    from ansys.geometry.core.misc.options import ImportOptions

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

stale

jacobrkerstetter · 2026-08-19T15:19:03Z

+    Warnings
+    --------
+    map_catia_sets_to_groups and publications_only_to_groups are only available
+    starting in version 27R1.

    Notes
    -----
    import_as_lightweight and import_using_spaceclaim_colors are only available
-    starting in version 2027 R1.
+    starting in version 27R1.


Can we move these sections to both be part of the "notes"? I think that makes it a little more concise.

jacobrkerstetter · 2026-08-19T15:20:35Z


  - version: "26.1"
    incompatible_tests:
+      # CATIA geometric-set mapping is not available in 26.1


Let's remove this solo comment

jacobrkerstetter · 2026-08-19T15:22:01Z

+def test_design_import_cat5_2024_with_catia_named_selections(modeler: Modeler):
+    """Test importing a 2024 CATIA V5 file with geometric sets mapped to named selections."""
+    options = ImportOptions(map_catia_sets_to_groups=True)
+    design = modeler.open_file(
+        Path(IMPORT_FILES_DIR, "CAT5/Bracket_Hole_2024.CATPart"), import_options=options
+    )
+    assert len(design.bodies) == 1
+    assert len(design.bodies[0].faces) == 24
+
+
+def test_design_import_cat5_2024_with_publications_to_groups(modeler: Modeler):
+    """Test importing a 2024 CATIA V5 file with publication groups enabled."""
+    options = ImportOptions(map_catia_sets_to_groups=True, publications_only_to_groups=True)
+    design = modeler.open_file(
+        Path(IMPORT_FILES_DIR, "CAT5/Bracket_Hole_2024.CATPart"), import_options=options
+    )
+    assert len(design.bodies) == 1
+    assert len(design.bodies[0].faces) == 24


These tests don't really show anything. The import options only really apply to models with NS and we aren't testing any NS here. I think we should remove them.

jacobrkerstetter · 2026-08-19T15:24:10Z

+def test_design_import_catia_named_selections_with_publications(modeler: Modeler):
+    """Test importing a CATIA V5 file with publications as named selection groups."""
+    options = ImportOptions(map_catia_sets_to_groups=True, publications_only_to_groups=True)
+    design = modeler.open_file(
+        Path(IMPORT_FILES_DIR, "SelectionSets.CATPart"), import_options=options
+    )
+    assert "GSMExtrude.1" in design._named_selections
+    assert len(design._named_selections["GSMExtrude.1"].bodies) == 1
+    assert "GSMFill.1" in design._named_selections
+    assert len(design._named_selections["GSMFill.1"].bodies) == 1
+    assert "Pad.1" in design._named_selections
+    assert len(design._named_selections["Pad.1"].bodies) == 1
+    assert "Pad.2" in design._named_selections
+    assert len(design._named_selections["Pad.2"].bodies) == 1
+    assert "Open_body.1" not in design._named_selections


This test is showing the same results as if you had none of the options set. @RyanJWard can you help us out here? What behavior is expected?

jacobrkerstetter · 2026-08-19T15:27:17Z

+    Warnings
+    --------
+    map_catia_sets_to_groups and publications_only_to_groups are only available
+    starting in version 27R1.

    Notes
    -----
    import_as_lightweight and import_using_spaceclaim_colors are only available
-    starting in version 2027 R1.
+    starting in version 27R1.


Suggested change

Warnings

--------

map_catia_sets_to_groups and publications_only_to_groups are only available

starting in version 27R1.

Notes

-----

import_as_lightweight and import_using_spaceclaim_colors are only available

starting in version 2027 R1.

starting in version 27R1.

Notes

-----

import_as_lightweight, import_using_spaceclaim_colors, map_catia_sets_to_groups, and publications_only_to_groups are only available starting in version 2027 R1.

I can't get the indentation correct but this is how it should look

Gonzi09 self-assigned this Aug 12, 2026

Gonzi09 requested a review from a team as a code owner August 12, 2026 19:48

github-actions Bot added the enhancement New features or code improvements label Aug 12, 2026

Gonzi09 marked this pull request as draft August 12, 2026 20:04

github-actions Bot added documentation Improvements or additions to documentation maintenance Package and maintenance related testing Anything related to tests and removed documentation Improvements or additions to documentation maintenance Package and maintenance related labels Aug 13, 2026

Gonzi09 marked this pull request as ready for review August 13, 2026 15:22

RobPasMue reviewed Aug 13, 2026

View reviewed changes

Comment thread tests/integration/test_design_import.py

Comment thread src/ansys/geometry/core/misc/options.py

Gonzi09 requested a lite review from Copilot August 14, 2026 05:58

Copilot started reviewing on behalf of Gonzi09 August 14, 2026 05:59 View session

Copilot AI reviewed Aug 14, 2026

View reviewed changes

Comment thread src/ansys/geometry/core/misc/options.py

Comment thread tests/integration/test_design_import.py Outdated

Gonzi09 marked this pull request as draft August 14, 2026 06:05

Gonzi09 and others added 9 commits August 17, 2026 09:31

feat: Added MapCatiaSetsToGroups Import Option

bda2421

test: Added tests for specific CATIA file

22df89d

chore: adding changelog file 3031.added.md [dependabot-skip]

e631e09

test: CI/CD tests fix

03f0998

test: Added missing tests and asserstions

6cfcc44

fix: Potential fix for pull request finding

7ac78d1

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

test: Fixed test assertions

bc1d268

test: Assertions done individually

cc09a54

test: Skipped unsupported tests

658a207

Gonzi09 force-pushed the feat/add-map-cts-to-grps branch from 5e6dfff to 658a207 Compare August 17, 2026 13:36

Merge branch 'main' into feat/add-map-cts-to-grps

95aeb64

Gonzi09 marked this pull request as ready for review August 17, 2026 19:41

jacobrkerstetter previously requested changes Aug 17, 2026

View reviewed changes

Comment thread src/ansys/geometry/core/misc/options.py Outdated

Comment thread tests/integration/test_design_import.py

Gonzi09 and others added 4 commits August 17, 2026 20:53

Merge branch 'main' into feat/add-map-cts-to-grps

310f21f

Merge branch 'main' into feat/add-map-cts-to-grps

81dec70

test: Condensed tests

44788ef

fix: Added version release warnings

a836411

Gonzi09 requested a review from jacobrkerstetter August 18, 2026 14:31

Gonzi09 and others added 5 commits August 18, 2026 10:52

refactor: Refactored warning messages

8e83b0c

test: Added incompatible test

320833a

Merge branch 'main' into feat/add-map-cts-to-grps

6c28310

Merge branch 'main' into feat/add-map-cts-to-grps

a325e6f

Merge branch 'main' into feat/add-map-cts-to-grps

219c306

jacobrkerstetter requested changes Aug 19, 2026

View reviewed changes

Gonzi09 marked this pull request as draft August 19, 2026 15:49

Merge branch 'main' into feat/add-map-cts-to-grps

e2f5499

Gonzi09 marked this pull request as ready for review September 14, 2026 15:28

Gonzi09 marked this pull request as draft September 14, 2026 15:28

Merge branch 'main' into feat/add-map-cts-to-grps

975cfcf

Navigation Menu

feat: Added MapCatiaSetsToGroups Import Option - #3031

feat: Added MapCatiaSetsToGroups Import Option#3031
Gonzi09 wants to merge 21 commits into
mainfrom
feat/add-map-cts-to-grps

Gonzi09 commented Aug 12, 2026 •

edited

Loading

Uh oh!

codacy-production Bot commented Aug 12, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Aug 12, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jacobrkerstetter Aug 19, 2026

Uh oh!

jacobrkerstetter Aug 19, 2026

Uh oh!

jacobrkerstetter Aug 19, 2026

Uh oh!

jacobrkerstetter Aug 19, 2026

Uh oh!

jacobrkerstetter Aug 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Gonzi09 commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issue linked

Checklist

Uh oh!

codacy-production Bot commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Up to standards ✅

Uh oh!

codecov Bot commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jacobrkerstetter Aug 19, 2026

Choose a reason for hiding this comment

Uh oh!

jacobrkerstetter Aug 19, 2026

Choose a reason for hiding this comment

Uh oh!

jacobrkerstetter Aug 19, 2026

Choose a reason for hiding this comment

Uh oh!

jacobrkerstetter Aug 19, 2026

Choose a reason for hiding this comment

Uh oh!

jacobrkerstetter Aug 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Gonzi09 commented Aug 12, 2026 •

edited

Loading

codacy-production Bot commented Aug 12, 2026 •

edited

Loading

codecov Bot commented Aug 12, 2026 •

edited

Loading