Skip to content

chore: deprecate manifest argument and remove deprecated methods - #3118

Merged
RobPasMue merged 8 commits into
mainfrom
chore/deprecate-manifest-arg
Sep 21, 2026
Merged

RobPasMue merged 8 commits into
mainfrom
chore/deprecate-manifest-arg

Conversation

@jacobrkerstetter

Copy link
Copy Markdown
Contributor

Description

  • Deprecating the custom manifest path argument on the Discovery launcher per Matteo's request.
  • Deprecate the launch_modeler_with_geometry_service() method and rename to launch_modeler_with_dms() as this was confusing to many users.
  • Removing the run_discovery_script_file() and save() methods as they were deprecated for removal in 0.17.0.

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jacobrkerstetter jacobrkerstetter self-assigned this Sep 18, 2026
@jacobrkerstetter
jacobrkerstetter requested a review from a team as a code owner September 18, 2026 16:00
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 2 duplication

Metric Results
Complexity 0
Duplication 2

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

RobPasMue
RobPasMue previously approved these changes Sep 21, 2026
RobPasMue and others added 2 commits September 21, 2026 10:42
@codecov

codecov Bot commented Sep 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.76%. Comparing base (ad6ea32) to head (9aadb4e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3118      +/-   ##
==========================================
- Coverage   93.79%   93.76%   -0.03%     
==========================================
  Files         195      195              
  Lines       18171    18164       -7     
==========================================
- Hits        17043    17031      -12     
- Misses       1128     1133       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RobPasMue
RobPasMue enabled auto-merge (squash) September 21, 2026 09:39
@RobPasMue
RobPasMue merged commit 8781bcb into main Sep 21, 2026
58 of 59 checks passed
@RobPasMue
RobPasMue deleted the chore/deprecate-manifest-arg branch September 21, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants