fix: bound chunk overlap and preserve generation capacity errors - #664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed-text overlap searched normalized decoded tokens in the original source. When case or punctuation differed, a failed match retained the entire previous chunk, producing growing embedding inputs and scratch contention during local RAG.
Use tokenizer byte offsets for overlap, validate the independently tokenized suffix, and count assembled source spans including separators. Reduce or omit overlap when the next section needs the room. Reuse validated candidate token counts on both the normal and overlap paths to avoid duplicate tokenization. Tokenizer errors propagate instead of retaining a prefix.
Preserve explicit retryable
MODEL_RESOURCE_BUSYHTTP 503 responses asGenerationCapacityUnavailablethrough both the local HTTP provider and in-process JSON generation bridge. Carry the error through the stable runtime ABI, return retryable RAG SSE/JSON failures, and return HTTP 503 with retry guidance for query planning. Permanent or malformed provider failures retain their existing generic failure behavior.Validation:
doneevent.git diff --checkpass.The retained quickstart dataset/model directory from the report is not available on this machine, so the complete real-model quickstart has not been replayed. Existing materialized chunks are not migrated by this change.