MINOR: Restrict trigger push branch for GitHub Workflow#1204
Open
apupier wants to merge 1 commit into
Open
Conversation
Feature branches rarely need their own CI runs: the code is already tested when a pull request is opened against a release branch. If the push trigger has no branch restriction and pull_request is also configured, every push to a branch with an open PR runs the workflow twice: once for the push and once for the PR synchronisation. Always give the push trigger an explicit list of branches: this stops branches created from a release branch from inheriting its workflow runs. see https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=430408443#GitHubActionsRecommendedPractices-Restrictthepushtriggertospecificbranches Signed-off-by: Aurélien Pupier <apupier@ibm.com>
apupier
requested review from
jbonofre,
kou,
laurentgo,
lidavidm and
wgtmac
as code owners
apupier
changed the title
This comment has been minimized.
This comment has been minimized.
Member
|
Is it not the same as the previous one? |
Member
|
FYI the previous one has been closed intentionally as not required. Can you elaborate why we would need this one? |
Author
no, this one is ignoring only the dependabot branches as agreed here #1202 (comment) with @kou |
Author
same reason as mentioned here #1202 (comment) after it was closed |
kou
approved these changes
Jul 3, 2026
kou
left a comment
kou
left a comment
Member
There was a problem hiding this comment.
+1
Could you update the PR description based of our PR template?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature branches rarely need their own CI runs: the code is already tested when a pull request is opened against a release branch. If the push trigger has no branch restriction and pull_request is also configured, every push to a branch with an open PR runs the workflow twice: once for the push and once for the PR synchronisation.
Always give the push trigger an explicit list of branches: this stops branches created from a release branch from inheriting its workflow runs.
see https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=430408443#GitHubActionsRecommendedPractices-Restrictthepushtriggertospecificbranches
What's Changed
Please fill in a description of the changes here.
This contains breaking changes.
Closes #NNN.
Note that I needed to recreate a PR as the previous one was closed #1202 (comment)