Skip to content

Fix ThreadSanitizer data races between bundle processing and async background writer closing in FileBasedSink and WriteFiles #39458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stankiewicz wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −4
Open

Fix ThreadSanitizer data races between bundle processing and async background writer closing in FileBasedSink and WriteFiles #39458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -905,15 +905,15 @@ public abstract static class Writer<DestinationT, OutputT> {
private final WriteOperation<DestinationT, OutputT> writeOperation;

/** Unique id for this output bundle. */
private @Nullable String id;
private volatile @Nullable String id;

private @Nullable DestinationT destination;
private volatile @Nullable DestinationT destination;

/** The output file for this bundle. May be null if opening failed. */
private @Nullable ResourceId outputFile;
private volatile @Nullable ResourceId outputFile;

/** The channel to write to. */
private @Nullable WritableByteChannel channel;
private volatile @Nullable WritableByteChannel channel;

/**
* The MIME type used in the creation of the output channel (if the file system supports it).
Expand Down
Loading