Fix module-level side effects and global random seeding#39462
Open
Abacn wants to merge 1 commit into
Open
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
… ML anomaly tests * Remove top-level dataset generation, stdout printing, and global seeding from perf_test.py by moving setup logic into PerfTest.setUpClass. * Replace calls to global random.seed() in perf_test.py, mean_test.py, quantile_test.py, and stdev_test.py with isolated random.Random instances. This prevents state leakage and unneeded computation when modules are imported during test collection.
Abacn
force-pushed
the
fix-leak-random-seed
branch
from
July 23, 2026 17:33
30d7e2b to
aa29e54
Compare
Contributor
Author
|
R: @shunping |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running unrelated tests, logs show the following lines
global random seed has been set accidentally
Remove top-level dataset generation, stdout printing, and global seeding from perf_test.py by moving setup logic into PerfTest.setUpClass.
Replace calls to global random.seed() in perf_test.py, mean_test.py, quantile_test.py, and stdev_test.py with isolated random.Random instances. This prevents state leakage and unneeded computation when modules are imported during test collection.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.