fix(ui): harden token costs refresh script - #876
Open
Ghraven wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The token-cost refresh script fetches LiteLLM's model pricing JSON and writes
model_costs.json, but the network request can hang indefinitely and HTTP failures are not surfaced explicitly. The generated JSON write also relied on the platform default text encoding.Before / after
Before:
requests.get()used no timeout.model_costs.jsonwas written with the default platform encoding.After:
raise_for_status(), andVerification
python -m py_compile telemetry/ui/scripts/token_costs.pytelemetry/ui/scripts/token_costs.pyfrom a temporary working directory and confirmed it generatedmodel_costs.jsongit diff --check