fix(tdigest): validate deserialized state invariants - #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Performance
The validation loops deliberately accumulate the floating-point predicates and branch once after each payload. This keeps valid-state deserialization on a straight-line fast path.
Paired Divan runs against
origin/mainon the same machine:origin/maindeserialize_partial_groups(large)deserialize_partial_groups(small)Allocation counts and bytes were unchanged. The speedup comes from fusing the former per-value NaN and finite checks into the structural validation pass; the main purpose of this PR remains rejecting malformed states rather than promising a particular performance gain.
Validation
cargo x prepare-testdatacargo x checkcargo x lintcargo x test