ci: build Windows test leg in Debug#806
Open
abnobdoss wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Let the CMake CI scripts use
ICEBERG_BUILD_TYPEand default toDebug, including on Windows. MSVC builds with debug info now use embedded/Z7debug info throughCMP0141andCMAKE_MSVC_DEBUG_INFORMATION_FORMATso Debug objects remain cacheable by sccache.The build scripts also use the same single-config Ninja build path on every platform. Since these jobs pass
-G Ninja,CMAKE_BUILD_TYPEcontrols the build and--config Release/ctest -C Releasewere not needed.Why
Windows was the only main
Testworkflow leg still forcing the helper scripts throughRelease. After this change, the helper-script CMake test jobs default toDebugon pull requests andmain;ICEBERG_BUILD_TYPEremains available if the project wants an override. Release verification and the SQL Catalog workflow's explicit WindowsReleasematrix entry are unchanged.The original Windows Debug blocker in #39 was an
IMPORTED_LOCATIONfailure from a multi-config CMake path. That specific failure no longer applies because the helper scripts now use Ninja single-config builds. The remaining Debug-only blocker was MSVC rejecting aconstexpr static PartitionValuestest helper:PartitionValuesowns astd::vector, and MSVC Debug's checked-iterator mode (_ITERATOR_DEBUG_LEVEL != 0) makes that construction fail constant evaluation. This PR constructs the emptyPartitionValuesat the call site instead.This follows the CI direction discussed in #799.
Validation
Fork validation passed:
Test / AMD64 Windows 2025passed in 23m48s on the pull-request run: https://github.com/abnobdoss/iceberg-cpp/actions/runs/28638474339/job/84929642907SQL Catalog / AMD64 Windows 2025passed in 4m13s: https://github.com/abnobdoss/iceberg-cpp/actions/runs/28638474303/job/84929643407Meson / AMD64 Windows 2025passed in 3m21s: https://github.com/abnobdoss/iceberg-cpp/actions/runs/28638474339/job/84929642897The Windows Debug test job reported 45% sccache hits, 385 hits, 477 misses, and 0 errors. The first post-merge Apache
mainrun will reseed Windows cache entries because the previous entries were built from Release objects.Closes #39.