Fix error in tests using paramiko > 4#2145
Open
micafer wants to merge 9 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #2145 +/- ##
==========================================
- Coverage 83.36% 83.34% -0.02%
==========================================
Files 351 351
Lines 81200 81202 +2
Branches 8939 8940 +1
==========================================
- Hits 67687 67672 -15
- Misses 10721 10737 +16
- Partials 2792 2793 +1
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Updates the project’s pinned dependencies and related code to keep the test suite compatible with newer Paramiko releases (>= 4 / now pinned to 5.0.0), while also refreshing a few related dependency/CI components.
Changes:
- Avoid direct use of
paramiko.DSSKey(removed in Paramiko >= 4) when building the SSH private key type list. - Bump Paramiko to
5.0.0and update the lockfile accordingly (including newly required transitive deps likeinvoke). - Minor updates to integration test client construction and CI workflow dependencies/actions.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
uv.lock |
Updates locked dependency set to match Paramiko 5.0.0 and related dependency graph changes. |
pyproject.toml |
Pins Paramiko to 5.0.0 in test/lint groups and adds explicit minimums for urllib3 and idna. |
libcloud/compute/ssh.py |
Switches DSS key handling to a safe getattr lookup to avoid referencing removed Paramiko symbols. |
integration/storage/test_azure_blobs.py |
Updates Azure resource client construction to use the newer module path. |
.github/workflows/main.yml |
Updates the pinned Codecov Action version used in CI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
119
to
+120
| - name: Upload Coverage to codecov.io | ||
| uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2 | ||
| uses: codecov/codecov-action@e53489f4d376d79066609109e7a95a29eb3740b1 # v7.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix error in tests using paramiko > 4
Description
Do not import directly
paramiko.DSSKeyas it does not exist in paramiko > 4And try also to fix other non-related errors, to make the tests pass.
The only unresolved problem is the security issue with the cryptography library, but newer versions require Python 3.11 or newer. So I will keep it until we decide to move the tests to a new python version.
Status
Checklist (tick everything that applies)