Skip to content

Fix error in tests using paramiko > 4#2145

Open
micafer wants to merge 9 commits into
trunkfrom
fix_paramiko
Open

Fix error in tests using paramiko > 4#2145
micafer wants to merge 9 commits into
trunkfrom
fix_paramiko

Conversation

@micafer

@micafer micafer commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Fix error in tests using paramiko > 4

Description

Do not import directly paramiko.DSSKey as it does not exist in paramiko > 4
And try also to fix other non-related errors, to make the tests pass.
The only unresolved problem is the security issue with the cryptography library, but newer versions require Python 3.11 or newer. So I will keep it until we decide to move the tests to a new python version.

Status

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

@codecov-commenter

codecov-commenter commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.34%. Comparing base (b3cca53) to head (d2bc3b5).

Files with missing lines Patch % Lines
libcloud/compute/ssh.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk    #2145      +/-   ##
==========================================
- Coverage   83.36%   83.34%   -0.02%     
==========================================
  Files         351      351              
  Lines       81200    81202       +2     
  Branches     8939     8940       +1     
==========================================
- Hits        67687    67672      -15     
- Misses      10721    10737      +16     
- Partials     2792     2793       +1     
Files with missing lines Coverage Δ
libcloud/compute/ssh.py 79.88% <0.00%> (-0.78%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project’s pinned dependencies and related code to keep the test suite compatible with newer Paramiko releases (>= 4 / now pinned to 5.0.0), while also refreshing a few related dependency/CI components.

Changes:

  • Avoid direct use of paramiko.DSSKey (removed in Paramiko >= 4) when building the SSH private key type list.
  • Bump Paramiko to 5.0.0 and update the lockfile accordingly (including newly required transitive deps like invoke).
  • Minor updates to integration test client construction and CI workflow dependencies/actions.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
uv.lock Updates locked dependency set to match Paramiko 5.0.0 and related dependency graph changes.
pyproject.toml Pins Paramiko to 5.0.0 in test/lint groups and adds explicit minimums for urllib3 and idna.
libcloud/compute/ssh.py Switches DSS key handling to a safe getattr lookup to avoid referencing removed Paramiko symbols.
integration/storage/test_azure_blobs.py Updates Azure resource client construction to use the newer module path.
.github/workflows/main.yml Updates the pinned Codecov Action version used in CI.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 119 to +120
- name: Upload Coverage to codecov.io
uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
uses: codecov/codecov-action@e53489f4d376d79066609109e7a95a29eb3740b1 # v7.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants