Conversation
Read and emit the flat one-model-per-document Ossie shape, reject removed wrappers and metadata, and preserve the existing Power BI round-trip contracts through updated tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Export can produce schema-invalid documents when all datasets are excluded or malformed.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Migrates the Microsoft converter to flat, one-model-per-document Ossie format and updates related tests, documentation, and CI coverage.
Changes:
- Supports flat document import/export and rejects legacy shapes.
- Updates round-trip and edge-case coverage.
- Expands CI path triggers.
A critical schema-validity issue remains when no exportable datasets exist.
| File | Description |
|---|---|
converters/microsoft/tests/test_tom_integration.py |
Updates TOM integration coverage. |
converters/microsoft/tests/test_semantic_model_to_ossie.py |
Tests flat export behavior. |
converters/microsoft/tests/test_ossie_to_semantic_model.py |
Tests flat import and rejection behavior. |
converters/microsoft/tests/test_edge_cases.py |
Covers converter edge cases. |
converters/microsoft/tests/conftest.py |
Updates shared test fixtures. |
converters/microsoft/src/ossie_microsoft/semantic_model_to_ossie.py |
Emits flat Ossie documents. |
converters/microsoft/src/ossie_microsoft/ossie_to_semantic_model.py |
Reads flat documents and rejects legacy shapes. |
converters/microsoft/README.md |
Documents the flat format. |
.github/workflows/converter-microsoft-ci.yml |
Expands CI path coverage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Prevent flat Ossie output with an empty datasets collection and cover the library and CLI failure paths requested in review. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jbonofre
self-requested a review
September 16, 2026 21:35
jbonofre
requested changes
Sep 17, 2026
Validate flat dataset roots before conversion, reject all-excluded models before warnings, and keep document metadata separate in shared fixtures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
@eisber thank you so much! I'm doing another pass. |
jbonofre
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
converters/microsoftto read and emit the flat one-model-per-document Ossie shape introduced by Define one semantic model per document without a wrapper #383semantic_modelwrappers and removed root metadata instead of ambiguously converting themReproduction
On current
mainbefore this change:test_all_tpcds_example_metrics_translate_to_daxfailed because the converter rejected the flat TPC-DS example as missingsemantic_modeltest_output_validates_against_core_spec_schemafailed because converter output still used the removed wrapper shapeValidation
ossie-microsoftimport/export round trip: passedcore-spec/ossie-schema.json: passedruff check converters/microsoft: passedgit diff --check: passedruff format --checkreports 16 pre-existing unformatted files, so this PR does not introduce a repository-wide formatting rewrite.Overlap
The Microsoft-scoped implementation matches the corresponding changes in #396. This PR is intentionally self-contained and limited to restoring the Microsoft converter CI path.