fix(honeydew): read and write flat semantic model documents - #420
Open
baruchoxman wants to merge 1 commit into
Open
baruchoxman wants to merge 1 commit into
baruchoxman wants to merge 1 commit into
Conversation
1 task
apache#383 moved the Ossie document schema to a single semantic model defined directly at the document root, and apache#397 dropped root-level `dialects` and `vendors`. The Honeydew converter still required the `semantic_model: [...]` wrapper, so it could not read any current Ossie document — including the TPC-DS example, which its own round-trip test loads. Read the model from the document root, emit `version` plus the model's properties with no wrapper, and drop the `vendors` round-trip (the field no longer exists in the schema, and `additionalProperties: false` now rejects it). A document that still carries the legacy wrapper gets an error that says how to migrate it. The dropped multi-model warning has no meaning now that a document holds exactly one model. Part of apache#418 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
baruchoxman
force-pushed
the
honeydew-flat-schema
branch
from
September 18, 2026 12:50
9226911 to
334105e
Compare
Contributor
Author
|
@jbonofre would appreciate you taking a look |
jbonofre
self-requested a review
September 18, 2026 13:02
Member
|
@baruchoxman absolutely. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #418, for
converters/honeydew. #383 moved the Ossie document schema to a single semantic model at the document root, and #397 dropped root-leveldialects/vendors. This converter still required thesemantic_model: [...]wrapper, so it could not read any current Ossie document — includingexamples/tpcds_semantic_model.yaml, which its own round-trip test loads. Its CI has not re-triggered since #383, so the break has been latent:test_ossie_roundtrip_tpcds_exampleis red onmaintoday.What changed
versionplus the model's properties at the root, with no wrapper.vendorsround-trip: root-levelvendorsno longer exists in the schema, and the root is nowadditionalProperties: false, so emitting it made the output invalid. This also removes theextra_vendorsplumbing through theossiemetadata section and thetest_vendors_roundtripcase that covered it.nameat the document root instead ofsemantic_model.name.Verification
The TPC-DS round-trip now works end to end, and its output validates against the official schema — the converter's first output that the validator has ever accepted since #383:
Test plan
cd converters/honeydew && uv sync && uv run pytest— 126 passed (128 onmain, of which 1 failed; net −3test_vendors_roundtripparams, +1 legacy-wrapper case)test_ossie_roundtrip_tpcds_examplepasses, having been red onmainpython3 validation/validate.pyaccepts the round-tripped TPC-DS document🤖 Generated with Claude Code