HDDS-15656. Fix non-atomic data size accumulation in ContainerBalancer move callback#10708
Open
sreejasahithi wants to merge 1 commit into
Open
HDDS-15656. Fix non-atomic data size accumulation in ContainerBalancer move callback#10708sreejasahithi wants to merge 1 commit into
sreejasahithi wants to merge 1 commit into
Conversation
chihsuan
reviewed
Jul 10, 2026
chihsuan
left a comment
chihsuan
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix! @sreejasahithi Overall LGTM. 👍
A couple of quick questions:
- With the callback now updating the metric live, is reading it in both the finished and unfinished paths in
getDataMoveInfointentional? - Would a small unit test be worth adding, or do the existing balancer tests cover it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When multiple container moves finish at the same time, each move runs a callback on its own thread.
The balancer was updating moved data size with a plain long (sizeActuallyMovedInLatestIteration += ...).
This update is not thread safe, so some bytes could be lost and the reported moved size could be low.
This PR updates moved bytes through the existing balancer metrics in the callback, the same way move counts are already updated.
What is the link to the Apache JIRA
HDDS-15656
How was this patch tested?
Green CI : https://github.com/sreejasahithi/ozone/actions/runs/29022183864