[codegen] Fix floating point record equaliser semantics#8534
Open
thswlsqls wants to merge 2 commits into
Open
Conversation
Use JDK floating-point comparison for generated FLOAT and DOUBLE equality so RecordEqualiser handles NaN and signed zero consistently with generated comparators. Generated-by: Claude Code
Generated-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
fix #8532
Float.compare(...) == 0andDouble.compare(...) == 0for floating-pointRecordEqualiserfields.BinaryRow.equals()/BinaryArray.equals()fast paths for compared type trees containingFLOATorDOUBLE.NaN, non-canonical NaN payloads, and signed-zero equality consistent with generated comparators after PR [codegen] Fix wrong sort order for float and double columns with nan #8295.Tests
EqualiserCodeGeneratorTest#testFloatingPointEqualiserMatchesJdkComparisonforNaN, non-canonical NaN payloads, signed zero, infinities, nested arrays, map keys, null map keys,GenericRow, hybrid rows, andBinaryRow/BinaryRow.mvn -pl paimon-codegen -DwildcardSuites=none -DfailIfNoTests=false -Dtest=EqualiserCodeGeneratorTest#testFloatingPointEqualiserMatchesJdkComparison testpassed, 1 test.mvn -pl paimon-codegen -DwildcardSuites=none -DfailIfNoTests=false -Dtest=EqualiserCodeGeneratorTest#testFloatingPointEqualiserMatchesJdkComparison clean installpassed, including compile, checkstyle, spotless, shade, install, and the regression test in both surefire phases.