[common] Fix map equality for binary keys#8536
Open
thswlsqls wants to merge 1 commit into
Open
Conversation
Compare internal map keys through the typed equality path before comparing values. This avoids Java array reference equality for binary keys. Generated-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
InternalRowUtils.equalsforMAP<BINARY, ...>keys by comparing map keys through typed equality instead of JavaMap.containsKey.Tests
mvn -pl paimon-common -DwildcardSuites=none -DfailIfNoTests=false -Dtest=InternalRowUtilsTest#testEqualsMapWithBinaryKeys testmvn -pl paimon-common -DwildcardSuites=none -DfailIfNoTests=false -Dtest=InternalRowUtilsTest testmvn spotless:apply -pl paimon-commonmvn -pl paimon-common -DfailIfNoTests=false clean installsame_entries=trueandhashes_equal=true; duplicate logical-key adversarial maps returnedfalsein both directions.