[python][ray] Fix HASH_FIXED primary-key writer ownership#8541
Open
QuakeWang wants to merge 1 commit into
Open
[python][ray] Fix HASH_FIXED primary-key writer ownership#8541QuakeWang wants to merge 1 commit into
QuakeWang wants to merge 1 commit into
Conversation
Ray map_groups keeps each group intact only while invoking the UDF. Its output can be split before a downstream datasink, so operator fusion changes can create multiple writers for one bucket and overlapping sequence numbers. Write each primary-key group inside the map_groups UDF and return serialized commit messages for the driver to commit. Apply writer task options to the group UDF and cover output splitting and overwrite behavior. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Ray
map_groupsonly keeps a(partition, bucket)group intact while the UDF runs. Its output may be split beforePaimonDatasink, so sink options that prevent operator fusion can create multiple independent writers for one bucket with overlapping sequence numbers.This change writes each HASH_FIXED primary-key group inside the
map_groupsUDF, returns serialized commit messages, and commits them on the driver. Writer concurrency and remote options are applied directly to the group tasks.Tests