Skip to content

[core] Fix copyWithLatestSchema option precedence#8550

Open
thswlsqls wants to merge 1 commit into
apache:masterfrom
thswlsqls:fix/copy-with-latest-schema-options
Open

[core] Fix copyWithLatestSchema option precedence#8550
thswlsqls wants to merge 1 commit into
apache:masterfrom
thswlsqls:fix/copy-with-latest-schema-options

Conversation

@thswlsqls

Copy link
Copy Markdown
Contributor

Purpose

fix #4957

  • copyWithLatestSchema() now lets the latest committed schema options override stale options from the current table copy, so altered option values survive a refresh.
  • Removes the obsolete TODO that described the previous broken precedence.

Tests

  • Added AppendOnlySimpleTableTest#testCopyWithLatestSchemaPicksUpAlteredOptionValues: alter snapshot.num-retained.max to 10, then assert copyWithLatestSchema() reflects it.
  • Failed before the fix with expected: 10 but was: 100; passes after.
  • mvn -pl paimon-core -am clean install ran the normal checks (checkstyle/spotless/rat); only PostgresqlCatalogTest was skipped for local Docker absence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] function copyWithLatestSchema() is not correct

1 participant