[fs] Fix GSFileIO to return actual file access time and owner#8559
Open
thswlsqls wants to merge 1 commit into
Open
[fs] Fix GSFileIO to return actual file access time and owner#8559thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
Generated-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
fix #8556
HadoopCompliantFileIO.HadoopFileStatusinpaimon-gs-impldid not overridegetAccessTime()/getOwner(), so on GCS file status always returned theFileStatusinterface defaults (0andnull) instead of the values carried by the wrapped HadoopFileStatus.HadoopFileIO+s3+oss ([core] Introduce Object Table to manage unstructured files #4459) and was added per module for the others; the later GS impl ([Feature] Add filesystem support for Google Cloud Storage #5238) omitted it.Tests
HadoopFileStatusis a private static delegation wrapper reachable only through a live GCSFileSystem; the five sibling impls merged the identical overrides without one.mvn -pl paimon-filesystems/paimon-gs-impl clean installpassed (compile + checkstyle + spotless + rat).