Skip to content

[Studio] fix: validate pasted message properties - #2159

Closed
yuluo-yx wants to merge 1 commit into
apache:rocketmq-studiofrom
yuluo-yx:0813-yuluo-yx/fix-19
Closed

[Studio] fix: validate pasted message properties#2159
yuluo-yx wants to merge 1 commit into
apache:rocketmq-studiofrom
yuluo-yx:0813-yuluo-yx/fix-19

Conversation

@yuluo-yx

@yuluo-yx yuluo-yx commented Aug 13, 2026

Copy link
Copy Markdown
Member

Summary

  • report malformed and empty-key batch property tokens
  • reject duplicate property names instead of overwriting values
  • preserve valid values after the first equals sign and block sending on parse errors

Fixes #2154

Validation

  • TopicPage.test.tsx: 13 passed
  • npm run build passed
  • targeted Prettier and ESLint passed
  • scope check: 81 changed lines

Base

rocketmq-studio at 737a7b4

@yuluo-yx
yuluo-yx force-pushed the 0813-yuluo-yx/fix-19 branch from ba498f1 to cbe93df Compare August 13, 2026 16:27

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

This PR extracts message property parsing into a dedicated utility (parseMessageProperties.ts) with proper validation for malformed entries, empty keys, and duplicate property names. The validation prevents sending messages with invalid properties and provides clear error feedback to users.

Good refactoring with comprehensive test coverage. LGTM.


Automated review by github-manager-bot

@lizhimins

Copy link
Copy Markdown
Member

Closing per contribution guideline #2107: these are fragmented one-off changes of the same theme (one PR per guard/fix/page). Please group related changes into cohesive pull requests and resubmit — your contributions are welcome in a consolidated shape.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants