Default release-passed.sh to the candidate that is actually in dist/dev - #219
Merged
Conversation
Publishing 0.11.0 failed at step 2 with an svn path error. The prompt offered 0.12.0, and pressing Enter accepted it: the default came from Chart.yaml, which release.sh had already bumped through the next-version PR. So the better the release manager had followed the process, the more certainly the default was the wrong version. It reads dist/dev now -- the one place that knows what is waiting to be published -- refuses to guess when there is more than one candidate, and checks the chosen version exists before asking whether the vote passed, rather than failing several prompts later on a path that was never going to be there.
wankai123
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publishing 0.11.0 failed at step 2:
The prompt offered 0.12.0 and pressing Enter accepted it. The default came from
Chart.yaml, whichrelease.shhad already bumped through the next-version PR — so the morefaithfully the release manager had followed the process, the more certainly the default was the
wrong version. There was a
NOTE:warning about exactly this, which is not the same as notdoing it.
It failed safely — nothing was moved,
dist/devstill holds0.11.0anddist/releasestillholds
0.10.0— but only after the vote confirmation, and with an svn path error rather than anexplanation.
Change
The default now comes from
dist/dev, the one place that knows what is waiting to be published:And the chosen version is checked to exist before the vote question, instead of failing
several prompts later.
Verified
The 0.11.0 candidate is untouched: 9 files still in
dist/dev.