Skip to content

test(verify): run a Python operator the way the engine runs it #8357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kz930 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

test(verify): run a Python operator the way the engine runs it #8357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
91f80d2
test(verify): run a Python operator the way the engine runs it
kz930 Sep 2, 2026
d2e8495
build: read the fork options once, outside the grouping loop
kz930 Sep 3, 2026
4659852
test(verify): call the plan preparation next door instead of copying it
kz930 Sep 3, 2026
1fb3581
test(verify): say it once, in the shape the code does not already give
kz930 Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,14 @@
Test / fork := true,
Test / forkOptions := (Test / forkOptions).value
.withWorkingDirectory((ThisBuild / baseDirectory).value),
Test / testGrouping := (Test / definedTests).value.map { suite =>
Tests.Group(suite.name, Seq(suite), Tests.SubProcess((Test / forkOptions).value))
Test / testGrouping := {
// Read once, outside the loop: sbt lifts a `.value` written inside a lambda to

Check warning on line 231 in build.sbt

View workflow job for this annotation

GitHub Actions / Bench 

The evaluation of `/` inside an anonymous function is prohibited.
// the top of the task anyway, so leaving it there reads as one lookup per suite
// when it is not, and sbt warns about exactly that.
val forked = (Test / forkOptions).value
(Test / definedTests).value.map { suite =>
Tests.Group(suite.name, Seq(suite), Tests.SubProcess(forked))
}
}
)

Expand All @@ -239,6 +245,7 @@
.dependsOn(WorkflowOperator)
lazy val WorkflowCompilingService = (project in file("workflow-compiling-service"))
.dependsOn(WorkflowCompiler, Auth, Config, Resource)
.dependsOn(WorkflowOperator % "test->test") // reuse PythonWorkerPool in verify tests
.settings(commonModuleSettings)
.settings(
dependencyOverrides ++= Seq(
Expand Down
Loading
Loading