refactor!: Export Apify storage clients under their real names#1046
Draft
vdusek wants to merge 6 commits into
Draft
refactor!: Export Apify storage clients under their real names#1046vdusek wants to merge 6 commits into
vdusek wants to merge 6 commits into
Conversation
vdusek
added
adhoc
github-actions
Bot
added
the
tested
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1046 +/- ##
=======================================
Coverage 91.75% 91.75%
=======================================
Files 50 50
Lines 3215 3216 +1
=======================================
+ Hits 2950 2951 +1
Misses 265 265
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…stemStorageClient BREAKING CHANGE: `apify.storage_clients.FileSystemStorageClient` is removed. Import `ApifyFileSystemStorageClient` instead (same class, unambiguous name that no longer shadows Crawlee's own `FileSystemStorageClient`).
vdusek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up inconsistencies in the public export surface of
apify.storage_clients.BREAKING CHANGE:
apify.storage_clients.FileSystemStorageClientnow refers to Crawlee'sFileSystemStorageClient, not the Apify variant. Previously the name was an alias for the Apify file-system client, which shadowed Crawlee's distinct class of the same name. UseApifyFileSystemStorageClientfor the Apify variant (the default local client).ApifyFileSystemStorageClientfromapify.storage_clientsunder its real name, and re-export Crawlee'sFileSystemStorageClientalongside it, so both distinct classes are available without shadowing.SmartApifyStorageClient, the tests, and the docs refer to the Apify variant by name.ApifyFileSystemDatasetClientfromapify.storage_clients._file_system, so the sub-package now re-exports all three of its client classes.MemoryStorageClienthas no Apify variant, so it's re-exported from Crawlee as-is and lacks the Apify INPUT-preservation-on-purge andPAY_PER_EVENTcharging behavior. Clarify theApifyFileSystemStorageClientdocstring (SDK variant with input handling and local PPE specifics).Configurationdocstring that referenced the removedactor.configproperty (nowActor.configuration).