fix(node): bump napi-rs to fix crash on concurrent response-body read errors#499
Merged
Merged
Conversation
… errors (#498) napi-rs 3.8.4's ReadableStream pull-callback (used by ImpitResponse's body streaming) could drop its resolver closure on a tokio worker thread when the underlying stream yielded Err, releasing a FunctionRef's V8 global handle off the JS thread. Under concurrent body-read errors (e.g. simultaneous read timeouts) this raced V8's GlobalHandles and crashed the process with SIGTRAP/SIGSEGV/SIGBUS. Bumping napi to 3.10.5 (and napi-derive/napi-build to their matching latest patch releases) resolves it — verified with the reporter's concurrent-timeout repro (8/8 clean 30s runs at 5 workers, previously crashing in ~1 of 5 runs). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014Jom9tSWtRxejUjvo53QpU
Member
Author
|
Running the repro script from the issue Before the fixes from this branch: 
After: 
|
B4nan
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #498