K2GO-384 feat(backup): real cancel + clean up the incomplete file - #537
Merged
Conversation
The backup's Cancel now actually stops the work and cleans up, and it has an on-screen button -- it was notification-only, and a fake cancel that marked the job done while tar kept running and then reported "Backup failed". - BackupEngine.streamBackup takes a cancel token; the read loop kills tar mid-stream. Backup is read-only, so cancel is always safe (no phases, no hold). - On cancel (or any failure that left an incomplete/damaged archive) the terminal removes the SAF file and, for a user cancel, returns to the bifurcation (CANCELLED) instead of a failure screen. A backup that finished just before the cancel took effect keeps its file. - Cleanup is automatic (a partial gzip'd tar is useless and unresumable); the on-screen confirm dialog only guards an accidental tap. - New cancel strings translated to 33 locales (machine-generated, pending review).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backup's Cancel now actually stops the work and cleans up, and it has an on-screen button -- it was notification-only, and a fake cancel that marked the job done while tar kept running and then reported "Backup failed".