test: fix newline container deletion assertion - #1103
Merged
Merged
Conversation
Member
Author
|
I'll merge once it passes |
|
🎉 This PR is included in version 14.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The newline container deletion test still expected a direct
run-asfilesystem check after #1102 addedsh -cfor older Android compatibility, causing unit tests to fail on master.Update the expected command to include the shell wrapper and nested quoting while preserving the complete newline-containing path. Also assert that deletion returns
true.Validation:
npm run build,npm run lint,npm run format:check, andnpm test(261 passing).