This repository was archived by the owner on Oct 2, 2026. It is now read-only.
fix: quote media scan destination paths - #321
Merged
Merged
Conversation
mykola-mokhnach
approved these changes
Sep 26, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Sep 26, 2026
## [8.0.10](v8.0.9...v8.0.10) (2026-09-26) ### Bug Fixes * quote media scan destination paths ([#321](#321)) ([71c90d0](71c90d0))
|
🎉 This PR is included in version 8.0.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scanMediapasses the destination as a rawam broadcast --es pathargument. Spaces split it, quotes can make the command invalid, and shell operators/newlines can truncate it. AndroidDriver uses this method after pushing files on Android API 29 and newer, so a successful push can still leave media scanning broken.Quote the complete destination as a POSIX literal, including embedded apostrophes. Add regression coverage for the emitted extra and real POSIX-shell argument preservation.
Validation: JavaScript/TypeScript build, formatting, and lint pass (two existing unrelated lint warnings). Windows unit suite: 7 pass, 1 POSIX case skipped; all 8 pass when the generated test uses Git sh. With published io.appium.settings 8.0.9, appium-adb 16.0.8, and the real Settings APK on an API 30 emulator, 9 of 10 path cases fail before this fix and all 10 succeed afterward. Device logcat confirms the exact paths were scanned, including spaces, both quote types, operators, newline, Japanese/emoji, and an apostrophe plus
!.The API 28-and-earlier AndroidDriver broadcast path is fixed separately in appium/appium-android-driver#1102.