GeneralPage: reflow General Settings into 3 columns - #27
Merged
Conversation
Split the vertically-stacked group boxes (Type of Analysis, Site Property Variation, Calculation Parameters, Layer Discretization) into two columns alongside the Project column, reducing the page's overall height for smaller/laptop screens. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Correct outdated build instructions (CMake Presets + vcpkg, not plain cmake/make), document the actual CTest regression test workflow via scripts/compare_examples.py, and clarify clang-format enforcement. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
setEditorData() called comboBox->addItems() every time it ran, but Qt re-invokes setEditorData() on the still-open editor whenever the model emits dataChanged() (not just once at editor creation). This duplicated the Type list, so ADVANCED_FEATURES builds showed 6 entries instead of the expected 3 (2 without ADVANCED_FEATURES). Move the addItems() call to createEditor(), which only runs once per editor. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Motion Input Location (and other depth drop-downs backed by DepthComboBox/DepthComboBoxDelegate) displayed a bare number for a specified depth, unlike the QDoubleSpinBox-based depth fields elsewhere which show a ' <unit>' suffix via Units::instance()->length(). setDepth() now appends the current length unit suffix to the item text. Added a parseDepth() helper that extracts the leading numeric value while ignoring a trailing unit suffix, used by depth() and the live-typing toDouble() slot so parsing still works with or without the suffix. Added an updateUnits() slot connected to Units::systemChanged so the suffix refreshes immediately if the unit system is changed while a depth is already specified. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GeneralPage("General Settings") layout from 2 columns (with one column stacking 4 group boxes vertically) into 3 columns to reduce vertical space on laptop screens..github/copilot-instructions.mdbuild/test/format sections to match the current CMake Presets + vcpkg workflow.Test plan
example-tests.yml) to build via CMake Presets + vcpkg and run the example regression tests, since this sandbox lacks a prebuilt Qt6/Qwt toolchain.Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com