Skip to content

Move play-tagged options into common_loop_options - #68

Open
Splendide-Imaginarius wants to merge 1 commit into
arkrow:masterfrom
Splendide-Imaginarius:unify
Open

Move play-tagged options into common_loop_options#68
Splendide-Imaginarius wants to merge 1 commit into
arkrow:masterfrom
Splendide-Imaginarius:unify

Conversation

@Splendide-Imaginarius

Copy link
Copy Markdown
Contributor

Remove the play-tagged command since it's now redundant.

Fixes #67

Remove the play-tagged command since it's now redundant.

Fixes arkrow#67
@Splendide-Imaginarius

Copy link
Copy Markdown
Contributor Author

This turned out to be much simpler than I was anticipating. Everything seems to work fine in my testing, but please do give it a look-over in case I missed some edge case. Hopefully the CLI compatibility break isn't a problem... I think this interface is a lot cleaner than the status quo, and I don't think it should be problematic for scripters to adapt to it, but it is admittedly still a backwards-incompatible change.

@Splendide-Imaginarius

Copy link
Copy Markdown
Contributor Author

@arkrow Any idea when you might be able to review this?

@Splendide-Imaginarius

Copy link
Copy Markdown
Contributor Author

@arkrow Status?

@Splendide-Imaginarius

Copy link
Copy Markdown
Contributor Author

@arkrow Is everything OK? No GitHub activity in over half a year.

@arkrow

arkrow commented Aug 17, 2026

Copy link
Copy Markdown
Owner

Hello @Splendide-Imaginarius,

Sorry for the long delay. I just haven't been able to commit the time this project needs lately with various life circumstances, but thanks for your contribution and continued interest.

With regards to this PR, the change is a great simplification for the CLI interface, but I believe it'd be preferable to keep the current CLI command and update it to be a facade/proxy to the new logic, while marking it as deprecated in the CLI help text. This way, we avoid introducing a breaking change in the CLI and keep the code lean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unify analysis and tagged commands

2 participants