feat: support compose-style interpolation in x-topo attributes - #413
Open
awphi wants to merge 1 commit into
Open
feat: support compose-style interpolation in x-topo attributes#413awphi wants to merge 1 commit into
awphi wants to merge 1 commit into
Conversation
awphi
marked this pull request as ready for review
August 18, 2026 10:05
Contributor
|
Wonder if we should scope it to |
muchzill4
reviewed
Aug 18, 2026
| Open http://${TOPO_TARGET_HOSTNAME:-localhost}:${WEB_PORT:-8080} | ||
| ``` | ||
|
|
||
| The `localhost` default keeps the Project usable with plain `docker compose`, where Topo does not provide `TOPO_TARGET_HOSTNAME`. |
Contributor
There was a problem hiding this comment.
docker compose doesn’t read x-topo anyway, so no need for a default.
awphi
marked this pull request as draft
August 18, 2026 15:13
Signed-off-by: awphi <26072111+awphi@users.noreply.github.com>
awphi
force-pushed
the
target-interpolation
branch
from
August 18, 2026 15:50
cd18cdc to
b15bae4
Compare
awphi
marked this pull request as ready for review
August 18, 2026 15:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
x-topo.deployment_success_messagecompose.ReadProjectin the post deploy step:TOPO_TARGET: the selected target for deploy/stop/psTOPO_TARGET_HOSTNAME: thessh -G-resolvedHostNameof the selected targetChecklist