Conversation
Two independent, version-independent fixes: 1. /rewriteGroups: the presence check had a stray semicolon (`if (!assertPresent(...));`) so it never returned on missing input, and getCachedContent() (async) was spread without await, so the cached disc was never actually merged into the rewrite. Add the return and await. 2. /upload: the acquired mutex was only released on the success path, so any aborted or stalled upload (client closes the tab, write throws) leaked the device lock and every later upload hung on mutex.acquire() forever. Hoist the release and free it on socket close/error and on failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small, version-independent fixes.
1.
/rewriteGroups— broken guard and missingawaitThe
;after theifmakes the presence check do nothing, andgetCachedContent()isasync, so...getCachedContent()spreads aPromiserather than the cached disc. Fixed by returning on the guard and awaiting the disc.2.
/upload— device lock leaks on aborted/stalled uploadsThe
mutexacquired for an upload is only released on the success path. If the client closes the tab, disconnects, or the write throws, the lock is never released — so every subsequent upload hangs forever onmutex.acquire()(looks like a permanent "stuck at 0%" until the server is restarted).Hoist the
releaseand free it on socketclose/errorand on failure, using afinished/terminalguard so a mid-stream parse error doesn't release the lock early.Both are independent of the netmd-js version.