rtp: Add tests to validate rtp merge and rollback on reINVITE - #150
Closed
mbradeen wants to merge 1 commit into
Closed
rtp: Add tests to validate rtp merge and rollback on reINVITE#150mbradeen wants to merge 1 commit into
mbradeen wants to merge 1 commit into
Conversation
Adds the following tests tests/channels/pjsip/rtp/payload_merge_initial_failure - Ensure that a failed offer resets the pending media state. tests/channels/pjsip/rtp/payload_merge_rollback - Ensure that an invalid offer on a reINVITE rolls back the SDP on offer to the pre-offer state tests/rtp/payload_merge - verify successful and failed media merges result in the expected offers
Contributor
Author
|
cherry-pick-to: 23 |
Contributor
Author
|
asterisk-test-pr: 2060 |
github-actions
Bot
added
pr-submit-testing-in-progress
pr-submit-tests-passed
and removed
pr-submit-testing-in-progress
labels
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Attention! This pull request may contain issues that could prevent it from being accepted. Please review the checklist below and take the recommended action. If you believe any of these are not applicable, just add a comment and let us know.
- The following
cherry-pick-tovalues are invalid: ["certified/22.8"]. Valid values are ["23","22","20","master"].
Documentation:
|
Workflow Check completed successfully |
jcolp
requested changes
Aug 5, 2026
| testinfo: | ||
| summary: 'Characterize RTP payload state retained across an uncommitted merge' | ||
| description: | | ||
| This test runs focused Asterisk unit tests for provisional RTP payload |
Member
There was a problem hiding this comment.
Why is there a testsuite test to run unit tests? Those are run separately, either manually or part of CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the following tests
tests/channels/pjsip/rtp/payload_merge_initial_failure - Ensure
that a failed offer resets the pending media state.
tests/channels/pjsip/rtp/payload_merge_rollback - Ensure that an
invalid offer on a reINVITE rolls back the SDP on offer to the
pre-offer state
tests/rtp/payload_merge - verify successful and failed media merges
result in the expected offers