Windows builds cannot hardlink from uv's cache, falling back to full copies - #1243
Open
vadikmironov wants to merge 1 commit into
Open
Windows builds cannot hardlink from uv's cache, falling back to full copies#1243vadikmironov wants to merge 1 commit into
vadikmironov wants to merge 1 commit into
Conversation
On GitHub's Windows runners the checkout lands on D: while uv's default cache is on C:. Because of that uv cannot hardlink into the build tree and warns that it falls back to full copies. Re-pointing the cache under the workspace fixes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On GitHub's Windows runners with standard checkout actions, the checkout lands on
D:while uv's default cache is on driveC:. During the build, this layout results in the following message from uv:Again, it's a minor Windows build noise issue and maybe a performance hit (cannot quantify, when hitting in my workflow I fixed it at the same time when introduced caching). Reproducible on every Windows run.
Pointing the cache at the workspace puts both on one volume and restores hardlinking:
I guess the existing behaviour might have come from the times when there was a single drive for the runner, but just not to depend on a particular layout I set the cache location relative to the workspace.