Skip to content

fix(navigation): rotate navbar dropdown chevron when menu is open - #5656

Open
Alwaysgaurav1 wants to merge 2 commits into
asyncapi:masterfrom
Alwaysgaurav1:fix/navbar-dropdown-chevron-rotation
Open

fix(navigation): rotate navbar dropdown chevron when menu is open#5656
Alwaysgaurav1 wants to merge 2 commits into
asyncapi:masterfrom
Alwaysgaurav1:fix/navbar-dropdown-chevron-rotation

Conversation

@Alwaysgaurav1

@Alwaysgaurav1 Alwaysgaurav1 commented Jul 26, 2026

Copy link
Copy Markdown

Description

Fixes an issue where the navigation dropdown chevron arrow did not remain rotated 180° when hovering or navigating inside the open dropdown flyout menu.

Changes Made

  • Updated components/icons/NavItemDropdown.tsx to accept a className prop and removed hardcoded group-hover:rotate-180 on the inner SVG.
  • Updated components/navigation/NavItem.tsx to apply isOpen ? 'rotate-180' : 'group-hover:rotate-180' on the chevron container to prevent 360° double-rotation bugs.

Summary by CodeRabbit

  • Style
    • Improved navigation dropdown arrow behavior with smoother visual rotation on hover and when menus are open.
    • Enabled more flexible styling for dropdown icons across navigation items.

@netlify

netlify Bot commented Jul 26, 2026

Copy link
Copy Markdown

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d737995
🔍 Latest deploy log https://app.netlify.com/projects/asyncapi-website/deploys/6a6d8be48e35fe00072da868
😎 Deploy Preview https://deploy-preview-5656--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a2cccc1d-2c85-4eaa-9332-6581cd3bb386

📥 Commits

Reviewing files that changed from the base of the PR and between 59bcbfb and 23d65f9.

📒 Files selected for processing (2)
  • components/icons/NavItemDropdown.tsx
  • components/navigation/NavItem.tsx

📝 Walkthrough

Walkthrough

Changes

Dropdown caret interaction

Layer / File(s) Summary
Caret styling and navigation integration
components/icons/NavItemDropdown.tsx, components/navigation/NavItem.tsx
NavItemDropdown accepts an optional className, and both navigation branches rotate the closed-state caret on group-hover while preserving open-state rotation.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: akshatnema, anshgoyalevil, asyncapi-bot-eve

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main navigation chevron rotation change in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@asyncapi-bot

asyncapi-bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 49
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-5656--asyncapi-website.netlify.app/

@sonarqubecloud

sonarqubecloud Bot commented Aug 1, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Be Triaged

Development

Successfully merging this pull request may close these issues.

2 participants