Public terminal management - #6
Open
root-expert wants to merge 4 commits into
Open
root-expert wants to merge 4 commits into
root-expert wants to merge 4 commits into
Conversation
added 4 commits
February 24, 2020 06:53
…the PATCH & PUT methods.
… to add implementation with the command (shutdown, restart, etc.) and later add the authentication(?) with the jwt.
… public-terminal-management
…only works if the client sends the values down, locked, up and logged_in. Also later I will have to implement the communication with the agent of the terminal for the command execution
enderian
reviewed
Mar 24, 2020
| return terminal_result.serialize() | ||
|
|
||
| # Checks if the client sends a (not-empty-also) json | ||
| def empty_json_body(f): |
There was a problem hiding this comment.
Really nice, but maybe rename it to something like @require_json_body?
|
|
||
| # PATCH: Update only the parameters we are given | ||
| if request.method == 'PATCH': | ||
| if changes['ip'] == None: # IP is not nullable |
There was a problem hiding this comment.
Maybe run this check in the model? We should check if validations are supported by SQAlchemy.
| return {"message": "Update successful"} | ||
|
|
||
| def update(self, changes): | ||
| madeChanges = 204 |
There was a problem hiding this comment.
Let's keep status codes out of the model classes, and reply inside the API classes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.