Skip to content

Stabilize the cold-launch deal animation - #103

Merged
austin-smith merged 2 commits into
mainfrom
stabilize-cold-launch-deal-animation
Aug 31, 2026
Merged

Stabilize the cold-launch deal animation#103
austin-smith merged 2 commits into
mainfrom
stabilize-cold-launch-deal-animation

Conversation

@austin-smith

@austin-smith austin-smith commented Aug 31, 2026

Copy link
Copy Markdown
Owner

What Changed

  • Hide fresh-board cards in the same state transaction that creates the deal.
  • Publish stock and destination frames as one coherent SwiftUI preference snapshot.
  • Tag each geometry snapshot with its board-deal event and reject stale generations, so identical redeals still republish current frames.
  • Start fresh-deal flights from an explicit stock or above-board source only after the required geometry exists.
  • Add regression coverage for atomic frame reduction, identical redeal geometry, and invalid deal sources.

Why

On a cold first launch with no saved game, the board could render before SwiftUI published complete geometry. Cards briefly appeared at their final positions, and a missing stock frame could make the deal originate from the top of the board. Identical redeals also preserve card IDs and positions, so their geometry must be distinguished by deal event rather than coordinates alone.

UI Changes

Eliminates the transient card flash, incorrect deal origin, and blank board after an unchanged redeal. There is no intended steady-state visual change.

Validation

  • macOS Debug build succeeded.
  • iOS Simulator Debug build succeeded.
  • Full macOS suite: 607 tests executed, 10 skipped, 0 failures.
  • NewGameDealAnimationTests: 17 tests, 0 failures.
  • git diff --check passed.
  • Autoreview and TruffleHog completed cleanly with no actionable findings.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-31T22:22:16.826940Z 54776a8 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c62817fa1c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ComputerSolitaire/Views/Shared/ContentView.swift Outdated
@austin-smith

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 54776a819b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@austin-smith
austin-smith merged commit bc010bd into main Aug 31, 2026
3 checks passed
@austin-smith
austin-smith deleted the stabilize-cold-launch-deal-animation branch August 31, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant